Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Dec 7, 2020

  • configure and use import mapping
  • cleanup import usage in dart-dio
  • add decimal support
  • handle reserved keywords in dart-dio

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

This prevents models from being generated which would clash with exisiting dart types, e.g. List.
* modelToIgnore is now handled via importMappings the same way other generators do this
* choose not to import dart:core as this is available by default
@kuhnroyal
Copy link
Contributor Author

@agilob FYI

@kuhnroyal
Copy link
Contributor Author

CC @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

@kuhnroyal
Copy link
Contributor Author

Build failure seems unrelated

@agilob
Copy link
Contributor

agilob commented Dec 8, 2020

Good job, dart generator might be finally usable soon

@kuhnroyal kuhnroyal deleted the dart/type-improvements branch December 15, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants