Skip to content

Conversation

@Havunen
Copy link
Contributor

@Havunen Havunen commented Dec 3, 2020

This PR fixes an issue where model contains property called "Formatting" or "JsonConvert" build fails to conflicting reference.
I tested opening generated sample projects in Visual Studio 2019 and compiled them.

The error being fixed:

Error CS1061	'Model' does not contain a definition for 'Indented' and no accessible extension method 'Indented' accepting a first argument of type 'Model' could be found (are you missing a using directive or an assembly reference?)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Havunen
Copy link
Contributor Author

Havunen commented Dec 3, 2020

@mandrean @frankyjuang @shibayan Please review, it seems I cannot assign for review, option is grayed out in Github

@Havunen
Copy link
Contributor Author

Havunen commented Dec 3, 2020

I dont understand how this circle ci failure is related to my change.

[ERROR] Plugin org.springframework.boot:spring-boot-maven-plugin:2.2.9.RELEASE or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.springframework.boot:spring-boot-maven-plugin:jar:2.2.9.RELEASE: Could not transfer artifact org.springframework.boot:spring-boot-maven-plugin:pom:2.2.9.RELEASE from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]

@wing328

@wing328
Copy link
Member

wing328 commented Dec 8, 2020

Pushed 816be37 to update the samples.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit d1ea6ac into OpenAPITools:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants