[dart] Cleanup and OAS3 support #8085
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
The new inline objects in OAS3 are caused by the PetAPI update with FormData operations. The same models are generated for java/kotlin etc. and are also unused. Why? |
|
Don't think we can generate a useful |
|
@wing328 This should be ready, CircleCI seems to have failed with some sort of timeout, maybe you can restart the step. |
* docs path seems to be doc now in all dart generators * generated tests are very old and use wrong classes
* remove duplicate/old openapi sample for which there is no generation config * generate to `petstore_client_lib` for both generators * run generated tests as integration tests for dart2 even if empty - this makes it easier to find compile errors
* globally ignore all dart related files that should not be commited * remove old ignores that are no longer valid
Dart2 doesn't compile, needs fixes.
Not sure if that case is ever relevant but for now there doesn't seem to be a better option.
Some POST operations now return 200 with content.
kuhnroyal
force-pushed
the
dart/cleanup-and-oas3
branch
from
f93fc9b to
8272de5
Compare
Explicitly not adding the new integration tests to the master POM. They do not work but having them allows for quickly iterating on open issues without breaking existing basic OAS2/OAS3 petstore examples. Instead they should be run manually until everything is fixed.
|
Not clear whats happening in CircleCI, seems to be related to some scala artifacts. |
These models are generated due to how form parameters are defined in OAS3. Usually these are not used. We'll revise accordingly given that it causes confusion to users. One way to prevent these from being generate is to set the |
2 participants
Explicitly not adding the new integration tests for petstore-with-fake-api to the master POM. They do not work but having them allows for quickly iterating on open issues without breaking existing basic OAS2/OAS3 petstore examples. Instead they should be run manually until everything is fixed.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterTODO:
200with content