-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Bump Gradle in generated Java projects to 6.7.1 #8079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regular maintenance, 6.0.1 was released November 18th, 2019 and the latest release (November 16th, 2020) is 6.7.1. This updates all the wrapper templatesto the latest version.
Generated via `./bin/generate-samples.sh bin/configs/java-*`
161607f to
e4f158a
Compare
|
I can't see what's going on with the circleci failure, so I can't really fix it. Is there some way to see the output? Or if someone has access to the build, can you paste the output? |
|
Restarted the job. Let's see how that goes. |
|
Verified the checksum of |
|
Looks like it failed again - does it look like an issue with the change, or is it some difficulty with the build? |
|
Ah, looks like I missed all the Java samples that did not follow the pattern |
|
|
|
Ah, I misunderstood
Is the descriptiveness in the pull request checklist helpful? I.e. is there a use case for not updating all the samples? I imagine I would have run the script on all samples had I not read (and misunderstood) that. Thanks for fixing this up - I wasn't going to get there (especially with no build output). |
|
Yup, simply run |
Bump the version of Gradle used in generated Java projects from 6.0.1 to 6.7.1
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)