Skip to content

Conversation

@tobymurray
Copy link
Contributor

@tobymurray tobymurray commented Dec 3, 2020

Bump the version of Gradle used in generated Java projects from 6.0.1 to 6.7.1

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

Regular maintenance, 6.0.1 was released November 18th, 2019 and the latest release (November 16th, 2020) is 6.7.1. This updates all the wrapper templatesto the latest version.
Generated via `./bin/generate-samples.sh bin/configs/java-*`
@tobymurray
Copy link
Contributor Author

tobymurray commented Dec 3, 2020

I can't see what's going on with the circleci failure, so I can't really fix it. Is there some way to see the output? Or if someone has access to the build, can you paste the output?

@wing328
Copy link
Member

wing328 commented Dec 4, 2020

Restarted the job. Let's see how that goes.

@wing328
Copy link
Member

wing328 commented Dec 4, 2020

Verified the checksum of modules/openapi-generator/src/main/resources/Java/gradle-wrapper.jar: e996d452d2645e70c01c11143ca2d3742734a28da2bf61f25c82bdc288c9e637

@tobymurray
Copy link
Contributor Author

Looks like it failed again - does it look like an issue with the change, or is it some difficulty with the build?

@tobymurray
Copy link
Contributor Author

Ah, looks like I missed all the Java samples that did not follow the pattern bin/configs/java-*. Is there a single command you use to update all Java samples?

@wing328
Copy link
Member

wing328 commented Dec 7, 2020

./bin/utils/ensure-up-to-date will update all samples and the docs

@tobymurray
Copy link
Contributor Author

tobymurray commented Dec 7, 2020

Ah, I misunderstood ./bin/generate-samples.sh. I read the suggestion to use java-* as an indication that that would generate the Java ones. Running it now with no arguments I see the changes you've added here.

You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*

Is the descriptiveness in the pull request checklist helpful? I.e. is there a use case for not updating all the samples? I imagine I would have run the script on all samples had I not read (and misunderstood) that.

Thanks for fixing this up - I wasn't going to get there (especially with no build output).

@wing328 wing328 merged commit cbe1fd9 into OpenAPITools:master Dec 7, 2020
@wing328
Copy link
Member

wing328 commented Dec 7, 2020

Yup, simply run ./bin/generate-samples.sh (called by ensure-up-to-date script) will do the job (in terms of updating samples).

@tobymurray tobymurray deleted the bump-java-gradle branch January 14, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants