Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Dec 2, 2020

(the test added by #7301 has NOT been deleted so stackoverflow issue is covered moving forward)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@wing328 wing328 added this to the 5.0.0 milestone Dec 2, 2020
@wing328 wing328 marked this pull request as ready for review December 2, 2020 09:31
@4brunu
Copy link
Contributor

4brunu commented Dec 2, 2020

Looks good to me 👍

@wing328 wing328 merged commit 82c5021 into master Dec 2, 2020
@wing328 wing328 deleted the fix_swift_example branch December 7, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants