Fix port when the URL doesn't have port specified #8049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| bundle.put("scheme", URLPathUtils.getScheme(url, config)); | ||
| bundle.put("host", url.getHost()); | ||
| if (url.getPort() != 80 && url.getPort() != 443 ) { | ||
| if (url.getPort() != 80 && url.getPort() != 443 && url.getPort() != -1) { |
Contributor
There was a problem hiding this comment.
I guess that does the trick but why was the port -1 to begin with? Some default value? Unfortunate conversion or something?
If there's no way to make it so it doesn't get the -1 value I suppose a comment explaining why -1 is a possible value and needs to be handled would help in the future.
Port 80 and 443 people can figure it out, -1, not so much I guess.
Member
Author
There was a problem hiding this comment.
The getPort() function is a part of URL class. The function getPort() returns the port of a specified URL. The function returns the port number or -1 if the port is not set
Ref: https://www.geeksforgeeks.org/url-getport-method-in-java-with-examples/
jfeltesse-mdsol
approved these changes
Nov 30, 2020
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #8047
TODO: will add a test case shortly
cc @OpenAPITools/generator-core-team
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master