[ruby] Improve ruby client examples #8040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
jirikuncar
reviewed
Nov 27, 2020
Contributor
There was a problem hiding this comment.
Suggested change
| return "\"" + codegenProperty.example + "\""; | |
| return "'" + codegenProperty.example + "'"; |
jirikuncar
reviewed
Nov 27, 2020
Contributor
There was a problem hiding this comment.
Suggested change
| return "\"" + codegenProperty.name + "_example\""; | |
| return "'" + codegenProperty.name + "_example'"; |
Contributor
Author
Member
|
Pushed 7e9f355 to update the samples so as to fix CircleCI build failure. Let's see how that goes. |
Contributor
Author
|
It seemed to do it, thanks 🙂 |
wing328
reviewed
Dec 4, 2020
Member
Member
|
@zippolyte when you've time, I wonder if you can resolve the merge conflicts. I'll put other Ruby PRs on hold for the time being. Have a nice weekend. |
zippolyte
force-pushed
the
hippo/ruby_ex
branch
3 times, most recently
from
a6200f4 to
76e9d5b
Compare
Contributor
Author
|
@wing328 I rebased, but now I'm not too sure why circle ci is failing. |
zippolyte
force-pushed
the
hippo/ruby_ex
branch
from
76e9d5b to
109716d
Compare
Contributor
Author
|
Hey @wing328, can you have another look at this one ? Thanks 🙇 |
Member
|
@zippolyte PR merged. Thanks for your contribution. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve ruby client examples for models, by building models with required properties set.
Goal is to have examples a bit more copy/pastable directly
Adds
constructExampleCodemethods, similarly to a few other clients like go, or powershellPR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master