Skip to content

Conversation

@dpolyakov987
Copy link
Contributor

@dpolyakov987 dpolyakov987 commented Nov 27, 2020

  • I do not understend how add to copy committee!! :(

To close #8036

PR checklist

  • [x ] Read the contribution guidelines.
  • [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x ] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x ] File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented Nov 27, 2020

@dpolyakov987 thanks for the PR. Please run ./bin/utils/ensure-up-to-date to update the samples so that CIs can verify the change.

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@dpolyakov987 dpolyakov987 force-pushed the fix_issue_8036 branch 3 times, most recently from 23565ec to af272c6 Compare November 30, 2020 12:58
@dpolyakov987
Copy link
Contributor Author

dpolyakov987 commented Nov 30, 2020

@wing328 done

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@dpolyakov987
Copy link
Contributor Author

@wing328 Hello. When pr will be merged? Unfortunately there is no replay :(

cc @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@wing328 wing328 added this to the 5.0.0 milestone Dec 4, 2020
@wing328 wing328 changed the title fix kotlin-spring generator does not add @Valid annotation to nested … Fix missing @Valid annotation to nested classes Dec 14, 2020
@wing328 wing328 changed the title Fix missing @Valid annotation to nested classes Fix missing @Valid annotation in the nested classes Dec 14, 2020
@wing328 wing328 merged commit 0cbf064 into OpenAPITools:master Dec 14, 2020
@wing328
Copy link
Member

wing328 commented Dec 14, 2020

@dpolyakov987 sorry for the delay. Just merged it. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][KOTLIN] kotlin-spring generator does not add @Valid annotation to nested classes

2 participants