Skip to content

Conversation

@therve
Copy link
Contributor

@therve therve commented Nov 17, 2020

When a model has an example in an array, it wrongly wraps it again in a list
instead of returning the list examples. This fixes it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

When a model has an example in an array, it wrongly wraps it again in a
list instead of returning the list examples. This fixes it.
@therve therve force-pushed the therve/fix-python-list-examples branch from 88d81d8 to b6dad11 Compare November 18, 2020 14:59
@wing328
Copy link
Member

wing328 commented Nov 20, 2020

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 157ad1c into OpenAPITools:master Nov 26, 2020
@wing328
Copy link
Member

wing328 commented Nov 26, 2020

@therve thanks for the PR, which has been merged into master. Do we need similar fix in the python-legacy client generator? https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonLegacyClientCodegen.java#L837

therve added a commit to therve/openapi-generator that referenced this pull request Nov 26, 2020
The patch in OpenAPITools#7967 forgot the prefix, this fixes it, and change the
sampels so that we can see the effect this time.
@therve
Copy link
Contributor Author

therve commented Nov 26, 2020

@therve thanks for the PR, which has been merged into master. Do we need similar fix in the python-legacy client generator? https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonLegacyClientCodegen.java#L837

I don't think so, because it doesn't seem to use the object example? Will try locally to make sure. Yes it needs a similar fix.

But that PR has a follow up unfortunately.

spacether pushed a commit that referenced this pull request Nov 26, 2020
The patch in #7967 forgot the prefix, this fixes it, and change the
sampels so that we can see the effect this time.
@wing328 wing328 added this to the 5.0.0 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants