-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Fix list examples in python #7967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list examples in python #7967
Conversation
When a model has an example in an array, it wrongly wraps it again in a list instead of returning the list examples. This fixes it.
88d81d8 to
b6dad11
Compare
|
cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11) |
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java
Show resolved
Hide resolved
wing328
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@therve thanks for the PR, which has been merged into master. Do we need similar fix in the |
The patch in OpenAPITools#7967 forgot the prefix, this fixes it, and change the sampels so that we can see the effect this time.
But that PR has a follow up unfortunately. |
The patch in #7967 forgot the prefix, this fixes it, and change the sampels so that we can see the effect this time.
When a model has an example in an array, it wrongly wraps it again in a list
instead of returning the list examples. This fixes it.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master