Skip to content

Conversation

@tray2100
Copy link
Contributor

@tray2100 tray2100 commented Nov 10, 2020

To fix #7913

Adding support for multi file upload. Also adding the option for individual CodeGens to specify a collectionFormat for CodegenParameters

  • updated samples as well

See the issue for details on the implementation.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC: @CodeNinjai @frol @cliffano @wing328

@wing328
Copy link
Member

wing328 commented Nov 23, 2020

@tray2100 thanks for the PR. Can you please resolve the merge conflicts when you've time?

@wing328
Copy link
Member

wing328 commented Nov 23, 2020

cc @OpenAPITools/generator-core-team as the PR impacts the Default Codegen class.

@tray2100
Copy link
Contributor Author

@wing328 You're welcome for the PR! I've resolved the conflicts.

…dding the option for individual CodeGens to specify a collectionFormat

* updated samples as well
@wing328 wing328 merged commit 8cfc9b0 into OpenAPITools:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [JS] Multi File Upload is not supported

2 participants