Skip to content

Conversation

@mattdowdell
Copy link
Contributor

As far as I can tell, the bulk of the work to support bearer tokens was already implemented to support OAuth, but never explicitly turned on. This was unexpectedly simple, so I susect I may have missed something.

Changes:

  • Added bearer token to the security features for rust server.
  • Supplemented the basic auth condition in the context template to handled basic auth and bearer token separately.
  • Repurpose an exising sample to confirm the code generation works as expected.

The new sample builds without problems, so the only possibly issue is that the underlying swagger crate didn't implement this. However, there's already bearer support in the client and it's also used in the OAuth support in the server, so I don't see why it wouldn't work.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @frol @farcaller @richardwhiuk @paladinzh

As far as I can tell, the bulk of the work to support bearer auth was already implemented to support OAuth, but never explicitly turned on. I've added a new sample which appears to be working correcltly, but I may have unwittingly overlooked something.

Changes:
- Added bearer auth to the security features for rust server
- Supplemented the basic auth condition in the context template to handled basic auth and bearer auth separately.
- Repurpose an exising sample to confirm the code generation works as expected.

The new sample builds without problems, so the only possibly issue is that the underlying `swagger` crate didn't implement this. However, there's already bearer support in the client and it's also used in the OAuth support in the server, so I don;t see why it wouldn't work.
@mattdowdell mattdowdell changed the title [Rust server] Add support for bearer token authentication [rust-server] Add support for bearer token authentication Oct 30, 2020
@richardwhiuk
Copy link
Contributor

Nope looks good to me. I think we've just not had a requirement to support Bearers outside of OAuth before, so it's just not come up.

Thanks!

@richardwhiuk richardwhiuk merged commit b4154be into OpenAPITools:master Jan 30, 2021
@richardwhiuk
Copy link
Contributor

richardwhiuk commented Jan 30, 2021

(Client support is already present -

{{#isBasicBearer}}
&AuthData::Bearer(ref bearer_header) => {
let auth = swagger::auth::Header(bearer_header.clone());
let header = match HeaderValue::from_str(&format!("{}", auth)) {
Ok(h) => h,
Err(e) => return Err(ApiError(format!("Unable to create Authorization header: {}", e)))
};
request.headers_mut().insert(
hyper::header::AUTHORIZATION,
header);
},
{{/isBasicBearer}}
)

@mattdowdell mattdowdell deleted the rust-server/bearerAuthSupport branch January 30, 2021 12:12
@wing328 wing328 added this to the 5.0.1 milestone Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants