Skip to content

Conversation

@Zomzog
Copy link
Contributor

@Zomzog Zomzog commented Oct 24, 2020

This PR will fix #7799. I also add a generation sample with the delegate pattern for the Kotlin/Spring generation because it contains a lot of differences compared to the "classic" generation.

@jimschubert (2017/09) , @dr4ke616 (2018/08) @karismann (2019/03) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Zomzog Zomzog force-pushed the 7799_kotlin_generated_annotation branch 2 times, most recently from bf3bdfa to 22fcf46 Compare October 30, 2020 21:05
restart tests
@Zomzog Zomzog force-pushed the 7799_kotlin_generated_annotation branch from 22fcf46 to 32d8686 Compare October 30, 2020 23:41
@Zomzog
Copy link
Contributor Author

Zomzog commented Oct 31, 2020

The error has been fixed in another PR, this one still contains a new sample to follow changes with delegate patterns?

@wing328
Copy link
Member

wing328 commented Dec 14, 2020

The new samples compile without issues 👍

I'll add it to the CI in another PR.

@wing328 wing328 merged commit 24fda2a into OpenAPITools:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] Deprecate assigning single elements to varargs in named form

2 participants