[cpp-restbed-server] Allow to implement validation of input data for enumerations #7717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping on this PR... |
Contributor
Author
|
Should I regen the petstore example files? |
f18m
changed the title
Contributor
Author
Contributor
Do you have changes if you regen, if so please commit them too. Changes seems OK |
Contributor
Author
done now! |
Contributor
etherealjoy
approved these changes
Nov 30, 2020
muttleyxd
approved these changes
Nov 30, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR modifies the MODEL C++ source code to throw an exception whenever trying to set an unsupported enum value inside the model class, instead of silently dropping the set() command.
This is consistent with the usage for the c++ restbed server of Boost::ptree which already throws exceptions in case of invalid data type translations (see https://www.boost.org/doc/libs/1_74_0/boost/property_tree/exceptions.hpp)
With this MR the caller can detect invalid JSON/schema provided as input to the REST APIs just by catching std::runtime_error exceptions. A possible improvement would be introducing a custom class for such exceptions...