Skip to content

Conversation

@mCzolko
Copy link
Contributor

@mCzolko mCzolko commented Aug 19, 2020

If the delegate is optional, put it as optional in constructor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

If the delegate is optional, put it as optional in constructor
@mCzolko mCzolko changed the title [kotlin-spring] Optional delegate in constructor [kotlin-spring] Optional delegate in ApiController constructor Aug 19, 2020
@mCzolko
Copy link
Contributor Author

mCzolko commented Aug 21, 2020

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

Copy link
Contributor

@Zomzog Zomzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 5.0.0 milestone Dec 14, 2020
@wing328 wing328 merged commit bc6da8c into OpenAPITools:master Dec 14, 2020
@wing328
Copy link
Member

wing328 commented Dec 14, 2020

@mCzolko sorry for the delay. Thanks for the PR, which has been merged into the master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants