Skip to content

[typescript] Add default values for typescript types#6871

Merged
macjohnny merged 2 commits into
OpenAPITools:masterfrom
softvision-dev:master
Jul 7, 2020
Merged

[typescript] Add default values for typescript types#6871
macjohnny merged 2 commits into
OpenAPITools:masterfrom
softvision-dev:master

Conversation

@svd-sea

@svd-sea svd-sea commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

I was building my own mustache template for typescript client generation and ran into the issue of all boolean and date property defaultValue fields always beeing set to undefined. This PR adds the missing defaultValue handling for typescript generators.

  • Added default values for DateTimeSchema, DateSchema and BooleanSchema.
  • Added simple tests for default value parsing

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

svd-sea added 2 commits July 6, 2020 16:19
* Added default values for DateTimeSchema, DateSchema and BooleanSchema.
* Added simple tests for default value parsing

@macjohnny macjohnny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for your contribution

@macjohnny macjohnny merged commit b3bc69c into OpenAPITools:master Jul 7, 2020
@macjohnny macjohnny added this to the 5.0.0 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants