Skip to content

Conversation

@spacether
Copy link
Contributor

@spacether spacether commented Jun 28, 2020

  • Removes code that converts to an object type CodegenModel when a non-object type CodegenModel with validations or enums is seen
  • Updates python-experimental ModelSimple templates to work correctly using a non-object type CodegenModel
  • Adds ComposedSchema serialization/deserialization of mixed types (NumberWithValidations/date/Animal)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@spacether spacether force-pushed the sp_python_exp_remove_codegemodel_mutation branch 3 times, most recently from c82eb1e to 74b382f Compare June 28, 2020 18:39
@spacether spacether changed the title Python-exp remove codegemodel mutation for ModelSimple clases Python-exp remove codegemodel mutation, allow mixed OneOf types Jun 29, 2020
@wing328
Copy link
Member

wing328 commented Jul 6, 2020

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@spacether
Copy link
Contributor Author

spacether commented Jul 6, 2020

cc ...

Thanks for adding this. On all of my other PR I have added them but for months now I have been the only active python reviewer so I have yet to see reviews on my PRs when I copying the python technical committee .

@spacether
Copy link
Contributor Author

Reopening to kick off ci

@spacether spacether force-pushed the sp_python_exp_remove_codegemodel_mutation branch 3 times, most recently from 6e96cab to 0dc0cf7 Compare July 14, 2020 06:39
@spacether spacether closed this Jul 16, 2020
@spacether spacether reopened this Jul 16, 2020
@spacether spacether force-pushed the sp_python_exp_remove_codegemodel_mutation branch from bef9815 to 0dc0cf7 Compare July 16, 2020 16:38
@spacether spacether force-pushed the sp_python_exp_remove_codegemodel_mutation branch from 0dc0cf7 to 637b647 Compare July 16, 2020 16:39
@spacether
Copy link
Contributor Author

The Shippable error is unrelated to this PR

@spacether spacether merged commit ed84280 into OpenAPITools:master Jul 18, 2020
@spacether spacether deleted the sp_python_exp_remove_codegemodel_mutation branch July 18, 2020 17:15
@spacether spacether added this to the 5.0.0 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants