[Rust Server] Bugfix #5969 (Not support free-form object code generated issue.) #5970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause there's no example" issue.
…g issue with raw string.
…tting isSelfReference flag.
…onId-blank issue.
AmateurECE
added a commit
to AmateurECE/openapi-generator
that referenced
this pull request
Jan 24, 2023
Issue OpenAPITools#5969 and PR OpenAPITools#5970 document an issue with rust-server where free form models are not generated. OpenAPITools#7373 adds some free form model generation to python-experimental (later ported to other languages, it seems), but this feature only covers two of three possible use cases. The third use case remains unimplemented, though it is used in some larger OpenAPI document sets, such as DMTF's Redfish schema (which contains 33 of these free form objects without validation). related functions), but there does not seem to be an adequate replacement for detecting free form objects in the OpenAPI data model from template context. Unfortunately, free form objects require special consideration in statically type-checked languages such as Rust. quickly closed, presumably because `isFreeFormObject` was still present in the data model at the time the issue was opened. This commit adds a global property (default `false`) called `generateFreeFormModels` (I'm taking suggestions for a better name) which enables generation for the third use case not addressed by OpenAPITools#7373. Additionally, isFreeFormObject is added back into the object model for any case where a free-form object is generated, allowing generators for languages such as Rust to handle them gracefully.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5969 [BUG] [Rust Server] Not support free-form object code generated issue.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.