-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[Spring] openapi-generator generates an incorrect stub for types named "Resource" #5855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wing328 Any help on this? The circleci fails with UNCOMMITTED CHANGES ERROR. I have run |
|
@jburgess I'll take a look tomorrow instead as it's pretty late here... |
|
I've updated the samples via 179136f. Restarted all the CI jobs. Let's see how it goes. (there was a github outage earlier causing the build to fail) |
|
Any help on getting this reviewed and into @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda |
|
This is the one issue we have right now. When can we expect it to be fixed? |
|
Unfortunately, this fix didn't make it into 4.3.1. I tried to resolve the merge conflicts, but gave up. There are a lot og changes that apply to the documentation. And then some in the PHP code/tests. Since this bug only concerns Spring, is it really necessary to add code for other languages as well? |
|
Closed via #8178 |
This fixes #1680 and #1888. It is based on work by @ErikGrimes.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda