-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[JAVA][SPRING] added missing getter for enum value #2346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JAVA][SPRING] added missing getter for enum value #2346
Conversation
|
@bilak please update the samples so that the CIs can test the change. Let me know if you need help on that. cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) |
|
@wing328 yes please guid me through update. Lastly when I did it, it failed on some parts. |
|
@bilak can you leave me a message via https://gitter.im so that I can share the steps with you? |
009f2a0 to
3e685f1
Compare
|
@wing328 what is wrong here please? Do I need to regenerate something? I've just rebased on master. |
|
@wing328 can this get to 4.x please? |
|
I restart the CircleCI job. Let's see if all the tests pass. |
3e685f1 to
3eeb9c1
Compare
3eeb9c1 to
3526147
Compare
|
@wing328 waht's wrong here? I've executed |
|
@bilak there are some problems with your PR. Please have a look at the result of the CI: https://circleci.com/gh/OpenAPITools/openapi-generator/8868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
|
@macjohnny can you help me with those? I don't understand what's wrong there. |
|
I think this is the relevant message: |
|
@macjohnny well I don't understand what's wrong there. The parameter of enum is String so the |
|
it is because there are two Lines 48 to 57 in 97b3581
I think similar to openapi-generator/modules/openapi-generator/src/main/resources/Java/modelEnum.mustache Lines 35 to 45 in bc6c94d
it the @JsonValue annotation should be removed from the toString() method.
see also https://www.baeldung.com/jackson-serialize-enums @jmini do you agree? |
|
@macjohnny does the last bug has something common with spring? I see problem in |
|
all tests in the CI pass, so we should wait for a review by the technical committee |
* Fix for Issue #2205 Because when we have tags on OpenAPI Specification, there can be more than 1 Feign Beans being generated and the title field is share by all the clients. This makes the code to stop working in runtime. Here is a PR which uses the classVarName instead, which follows the standards and should be enough to solve this issue. For more info please refer to: #2205 * fix java feign parameter request name (#4883) * update sprign cloud feign sample * [JAVA][SPRING][2195] added missing getter for enum value (#2346) * [2195] added missing getter for enum value * updated samples * re-generate spring samples * Removed @jsonvalue from toString and regenerated samples * re-generate spring samples Co-authored-by: Esteban Gehring <[email protected]> * update samples * [kotlin][client] make Request date converter toJson as default * [kotlin][client] update windows scripts * [kotlin][client] update docs * [kotlin][client] update scripts * [kotlin][client] update scripts Co-authored-by: Filipe Manuel Couto Pinheiro <[email protected]> Co-authored-by: William Cheng <[email protected]> Co-authored-by: Lukáš Vasek <[email protected]> Co-authored-by: Esteban Gehring <[email protected]>
fixes #2195