Skip to content

Removal of number being default to example in python client #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Feb 25, 2019
Merged

Removal of number being default to example in python client #2228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1359726
remove number default to example in python client
wing328 Feb 25, 2019
c05e407
update python samples
wing328 Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...enapi-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,6 @@ public String toDefaultValue(Schema p) {
if (p.getDefault() != null) {
return p.getDefault().toString();
}
if (p.getExample() != null) {
return p.getExample().toString();
}
} else if (ModelUtils.isIntegerSchema(p)) {
if (p.getDefault() != null) {
return p.getDefault().toString();
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-asyncio/docs/TypeHolderExample.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**string_item** | **str** | |
**number_item** | **float** | | [default to 1.234]
**number_item** | **float** | |
**integer_item** | **int** | |
**bool_item** | **bool** | |
**array_item** | **list[int]** | |
Expand Down
10 changes: 5 additions & 5 deletions samples/client/petstore/python-asyncio/docs/XmlItem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,30 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**attribute_string** | **str** | | [optional]
**attribute_number** | **float** | | [optional] [default to 1.234]
**attribute_number** | **float** | | [optional]
**attribute_integer** | **int** | | [optional]
**attribute_boolean** | **bool** | | [optional]
**wrapped_array** | **list[int]** | | [optional]
**name_string** | **str** | | [optional]
**name_number** | **float** | | [optional] [default to 1.234]
**name_number** | **float** | | [optional]
**name_integer** | **int** | | [optional]
**name_boolean** | **bool** | | [optional]
**name_array** | **list[int]** | | [optional]
**name_wrapped_array** | **list[int]** | | [optional]
**prefix_string** | **str** | | [optional]
**prefix_number** | **float** | | [optional] [default to 1.234]
**prefix_number** | **float** | | [optional]
**prefix_integer** | **int** | | [optional]
**prefix_boolean** | **bool** | | [optional]
**prefix_array** | **list[int]** | | [optional]
**prefix_wrapped_array** | **list[int]** | | [optional]
**namespace_string** | **str** | | [optional]
**namespace_number** | **float** | | [optional] [default to 1.234]
**namespace_number** | **float** | | [optional]
**namespace_integer** | **int** | | [optional]
**namespace_boolean** | **bool** | | [optional]
**namespace_array** | **list[int]** | | [optional]
**namespace_wrapped_array** | **list[int]** | | [optional]
**prefix_ns_string** | **str** | | [optional]
**prefix_ns_number** | **float** | | [optional] [default to 1.234]
**prefix_ns_number** | **float** | | [optional]
**prefix_ns_integer** | **int** | | [optional]
**prefix_ns_boolean** | **bool** | | [optional]
**prefix_ns_array** | **list[int]** | | [optional]
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-asyncio/petstore_api/models/type_holder_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class TypeHolderExample(object):
'array_item': 'array_item'
}

def __init__(self, string_item=None, number_item=1.234, integer_item=None, bool_item=None, array_item=None): # noqa: E501
def __init__(self, string_item=None, number_item=None, integer_item=None, bool_item=None, array_item=None): # noqa: E501
"""TypeHolderExample - a model defined in OpenAPI""" # noqa: E501

self._string_item = None
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-asyncio/petstore_api/models/xml_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class XmlItem(object):
'prefix_ns_wrapped_array': 'prefix_ns_wrapped_array'
}

def __init__(self, attribute_string=None, attribute_number=1.234, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=1.234, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=1.234, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=1.234, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=1.234, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
def __init__(self, attribute_string=None, attribute_number=None, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=None, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=None, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=None, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=None, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
"""XmlItem - a model defined in OpenAPI""" # noqa: E501

self._attribute_string = None
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-tornado/docs/TypeHolderExample.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**string_item** | **str** | |
**number_item** | **float** | | [default to 1.234]
**number_item** | **float** | |
**integer_item** | **int** | |
**bool_item** | **bool** | |
**array_item** | **list[int]** | |
Expand Down
10 changes: 5 additions & 5 deletions samples/client/petstore/python-tornado/docs/XmlItem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,30 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**attribute_string** | **str** | | [optional]
**attribute_number** | **float** | | [optional] [default to 1.234]
**attribute_number** | **float** | | [optional]
**attribute_integer** | **int** | | [optional]
**attribute_boolean** | **bool** | | [optional]
**wrapped_array** | **list[int]** | | [optional]
**name_string** | **str** | | [optional]
**name_number** | **float** | | [optional] [default to 1.234]
**name_number** | **float** | | [optional]
**name_integer** | **int** | | [optional]
**name_boolean** | **bool** | | [optional]
**name_array** | **list[int]** | | [optional]
**name_wrapped_array** | **list[int]** | | [optional]
**prefix_string** | **str** | | [optional]
**prefix_number** | **float** | | [optional] [default to 1.234]
**prefix_number** | **float** | | [optional]
**prefix_integer** | **int** | | [optional]
**prefix_boolean** | **bool** | | [optional]
**prefix_array** | **list[int]** | | [optional]
**prefix_wrapped_array** | **list[int]** | | [optional]
**namespace_string** | **str** | | [optional]
**namespace_number** | **float** | | [optional] [default to 1.234]
**namespace_number** | **float** | | [optional]
**namespace_integer** | **int** | | [optional]
**namespace_boolean** | **bool** | | [optional]
**namespace_array** | **list[int]** | | [optional]
**namespace_wrapped_array** | **list[int]** | | [optional]
**prefix_ns_string** | **str** | | [optional]
**prefix_ns_number** | **float** | | [optional] [default to 1.234]
**prefix_ns_number** | **float** | | [optional]
**prefix_ns_integer** | **int** | | [optional]
**prefix_ns_boolean** | **bool** | | [optional]
**prefix_ns_array** | **list[int]** | | [optional]
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-tornado/petstore_api/models/type_holder_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class TypeHolderExample(object):
'array_item': 'array_item'
}

def __init__(self, string_item=None, number_item=1.234, integer_item=None, bool_item=None, array_item=None): # noqa: E501
def __init__(self, string_item=None, number_item=None, integer_item=None, bool_item=None, array_item=None): # noqa: E501
"""TypeHolderExample - a model defined in OpenAPI""" # noqa: E501

self._string_item = None
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python-tornado/petstore_api/models/xml_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class XmlItem(object):
'prefix_ns_wrapped_array': 'prefix_ns_wrapped_array'
}

def __init__(self, attribute_string=None, attribute_number=1.234, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=1.234, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=1.234, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=1.234, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=1.234, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
def __init__(self, attribute_string=None, attribute_number=None, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=None, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=None, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=None, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=None, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
"""XmlItem - a model defined in OpenAPI""" # noqa: E501

self._attribute_string = None
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python/docs/TypeHolderExample.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**string_item** | **str** | |
**number_item** | **float** | | [default to 1.234]
**number_item** | **float** | |
**integer_item** | **int** | |
**bool_item** | **bool** | |
**array_item** | **list[int]** | |
Expand Down
10 changes: 5 additions & 5 deletions samples/client/petstore/python/docs/XmlItem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,30 @@
Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**attribute_string** | **str** | | [optional]
**attribute_number** | **float** | | [optional] [default to 1.234]
**attribute_number** | **float** | | [optional]
**attribute_integer** | **int** | | [optional]
**attribute_boolean** | **bool** | | [optional]
**wrapped_array** | **list[int]** | | [optional]
**name_string** | **str** | | [optional]
**name_number** | **float** | | [optional] [default to 1.234]
**name_number** | **float** | | [optional]
**name_integer** | **int** | | [optional]
**name_boolean** | **bool** | | [optional]
**name_array** | **list[int]** | | [optional]
**name_wrapped_array** | **list[int]** | | [optional]
**prefix_string** | **str** | | [optional]
**prefix_number** | **float** | | [optional] [default to 1.234]
**prefix_number** | **float** | | [optional]
**prefix_integer** | **int** | | [optional]
**prefix_boolean** | **bool** | | [optional]
**prefix_array** | **list[int]** | | [optional]
**prefix_wrapped_array** | **list[int]** | | [optional]
**namespace_string** | **str** | | [optional]
**namespace_number** | **float** | | [optional] [default to 1.234]
**namespace_number** | **float** | | [optional]
**namespace_integer** | **int** | | [optional]
**namespace_boolean** | **bool** | | [optional]
**namespace_array** | **list[int]** | | [optional]
**namespace_wrapped_array** | **list[int]** | | [optional]
**prefix_ns_string** | **str** | | [optional]
**prefix_ns_number** | **float** | | [optional] [default to 1.234]
**prefix_ns_number** | **float** | | [optional]
**prefix_ns_integer** | **int** | | [optional]
**prefix_ns_boolean** | **bool** | | [optional]
**prefix_ns_array** | **list[int]** | | [optional]
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python/petstore_api/models/type_holder_example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class TypeHolderExample(object):
'array_item': 'array_item'
}

def __init__(self, string_item=None, number_item=1.234, integer_item=None, bool_item=None, array_item=None): # noqa: E501
def __init__(self, string_item=None, number_item=None, integer_item=None, bool_item=None, array_item=None): # noqa: E501
"""TypeHolderExample - a model defined in OpenAPI""" # noqa: E501

self._string_item = None
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/python/petstore_api/models/xml_item.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class XmlItem(object):
'prefix_ns_wrapped_array': 'prefix_ns_wrapped_array'
}

def __init__(self, attribute_string=None, attribute_number=1.234, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=1.234, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=1.234, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=1.234, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=1.234, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
def __init__(self, attribute_string=None, attribute_number=None, attribute_integer=None, attribute_boolean=None, wrapped_array=None, name_string=None, name_number=None, name_integer=None, name_boolean=None, name_array=None, name_wrapped_array=None, prefix_string=None, prefix_number=None, prefix_integer=None, prefix_boolean=None, prefix_array=None, prefix_wrapped_array=None, namespace_string=None, namespace_number=None, namespace_integer=None, namespace_boolean=None, namespace_array=None, namespace_wrapped_array=None, prefix_ns_string=None, prefix_ns_number=None, prefix_ns_integer=None, prefix_ns_boolean=None, prefix_ns_array=None, prefix_ns_wrapped_array=None): # noqa: E501
"""XmlItem - a model defined in OpenAPI""" # noqa: E501

self._attribute_string = None
Expand Down