Skip to content

Conversation

@vlsergey
Copy link
Contributor

@vlsergey vlsergey commented Mar 9, 2022

In future kotlinx serialization shall be added.

I'm not sure if this library shall supersede "multiplatform" library or leave it as it is. But ktor+jackson shall be present for sure.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 4, 2022

Tested locally and the result is good.

CircleCI failure not related to this change.

@wing328 wing328 merged commit 6bd7036 into OpenAPITools:master May 4, 2022
@wing328
Copy link
Member

wing328 commented May 4, 2022

FYI. I've updated GitHub workflow to test the new samples via ee038e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants