Skip to content

Conversation

@sullis
Copy link
Contributor

@sullis sullis commented Jan 22, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sullis sullis force-pushed the javaparser-3.24.0 branch from 4141e50 to 1e919f1 Compare January 22, 2022 19:17
@wing328 wing328 added this to the 5.4.0 milestone Jan 24, 2022
@wing328 wing328 merged commit e9d69f2 into OpenAPITools:master Jan 24, 2022
@wing328
Copy link
Member

wing328 commented Jan 24, 2022

@sullis sullis deleted the javaparser-3.24.0 branch January 24, 2022 02:48
@sullis
Copy link
Contributor Author

sullis commented Feb 8, 2022

@sullis thanks for the PR, which has been merged.

When you've time, please PM me via Slack: https://join.slack.com/t/openapi-generator/shared_invite/enQtNzAyNDMyOTU0OTE1LTY5ZDBiNDI5NzI5ZjQ1Y2E5OWVjMjZkYzY1ZGM2MWQ4YWFjMzcyNDY5MGI4NjQxNDBiMTlmZTc5NjY2ZTQ5MGM.

Slack UI says "This link is no longer active" @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants