Skip to content

Conversation

@vanjur
Copy link
Contributor

@vanjur vanjur commented Nov 21, 2021

This fix addresses a python regex formatting issue for OpenAPI declaration yaml files where a backslash \ after an opening bracket [ can cause a double backslash \ in the outputted sample Default API file, and the produced validation test for the Default API will then fail.
The added code removes the backslash so the output in the Default API file is a single \ instead of a double, and the regex validation passes.

This is to fix issue #6675

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 25, 2021

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

@wing328
Copy link
Member

wing328 commented Jan 24, 2022

Update samples via ce63757

@wing328
Copy link
Member

wing328 commented Jan 24, 2022

All tests passed. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants