-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Java playframework: add support for oauth2 accesstoken validation #10901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java playframework: add support for oauth2 accesstoken validation #10901
Conversation
…mustache test file.
Sync with latest openapi master
…utablejs # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModel.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenParameter.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenProperty.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptFetchClientCodegen.java # modules/openapi-generator/src/main/resources/typescript-fetch/models.index.mustache # modules/openapi-generator/src/test/java/org/openapitools/codegen/options/TypeScriptFetchClientOptionsProvider.java # modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchClientOptionsTest.java
…Model used exclusively by TypescriptFetchClient. Adding missing samples files.
…egenOperation used exclusively by TypescriptFetchClient.
…genProperty used exclusively by TypescriptFetchClient.
…egenParameter used exclusively by TypescriptFetchClient.
…l concept of "operation return passthrough"
…dependencies in models and other special cases. Also fixed issues with default values for some records properties.
…s in some cases. Fix issues with enum default values.
…s in some cases. Fix issues with enum default values.
merge latest openapi
… that cannot be used in Records. Added missing export to record: toApi().
…uilt-in "reserved words" feature. Fix minor issues with typings in generated files.
…licts. Added generated ApiEntities (record, reducer & selector) files.
Merge openapi master
|
There is currently an issue when "useInterfaces: false". This is why one of the build steps failed. I will fix this. |
…asses when "useInterfaces = false"
|
Can someone please take a look at reviewing/merging this? |
modules/openapi-generator/src/main/resources/JavaPlayFramework/module.mustache
Outdated
Show resolved
Hide resolved
...api-generator/src/main/java/org/openapitools/codegen/languages/JavaPlayFrameworkCodegen.java
Show resolved
Hide resolved
samples/server/petstore/java-play-framework-async/app/openapitools/SecurityAPIUtils.java
Show resolved
Hide resolved
samples/server/petstore/java-play-framework-api-package-override/app/Module.java
Outdated
Show resolved
Hide resolved
…iguration variables are not found. fix minor issue with space vs tab in mustache files. Fix compilation issues in some cases when using async mode.
merge master
…add_support_for_oauth2_accesstoken_validation
JFCote
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@bflamand Can you update your branch. It should fix the Docs up to date and Samples up to date test. |
|
yep, I was already on this... |
|
@bflamand not sure why it's not passing but it's not your fault since you generated the related samples. I will let the others from the technical committee validate this and merge. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01) |
This reverts commit da4d3ac.
|
I agree @JFCote... I really generated all playframework samples, etc. |
|
@bflamand thanks for the PR. My only suggestion is regarding the following: Can we use kebab-case instead as that's the convention we've in this project? i.e. Please feel free to update it in a separate PR as I'll merge this one for the time being. |
…arta namespace Summary: Current openapi-generator version only supports the javax namespace, which is used by Spring v5.x. However, as part of [[ https://yugabyte.atlassian.net/browse/PLAT-18516 | PLAT-18516 ]], we need to upgrade to Spring 6.x since 5.x is already EOLed. We are updating the openapi-generator templates to version 7.17. This update is being done by inspecting the commits went between 5.x and 7.17 and applying them manually to each file. Version 7.17 also introduces an in-built way to perform OAuth 0 token validation (ref: PR [[ OpenAPITools/openapi-generator#10901 | #10901) ]]. However, this feature has been commented out for now since YBA already relies on pac4j for authentication. Test Plan: Tested locally dev-itests unit tests v2 iTests Reviewers: #yba-api-review, sneelakantan, dkumar, aaryan.chauhan Reviewed By: #yba-api-review, sneelakantan Subscribers: yugaware Differential Revision: https://phorge.dev.yugabyte.com/D48223
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@JFCote