Skip to content

Conversation

@bflamand
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @JFCote

bflamand-work and others added 30 commits September 29, 2020 15:13
Sync with latest openapi master
…utablejs

# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenModel.java
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenParameter.java
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenProperty.java
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptFetchClientCodegen.java
#	modules/openapi-generator/src/main/resources/typescript-fetch/models.index.mustache
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/options/TypeScriptFetchClientOptionsProvider.java
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchClientOptionsTest.java
…Model used exclusively by TypescriptFetchClient. Adding missing samples files.
…egenOperation used exclusively by TypescriptFetchClient.
…genProperty used exclusively by TypescriptFetchClient.
…egenParameter used exclusively by TypescriptFetchClient.
…dependencies in models and other special cases. Also fixed issues with default values for some records properties.
…s in some cases. Fix issues with enum default values.
…s in some cases. Fix issues with enum default values.
… that cannot be used in Records. Added missing export to record: toApi().
…uilt-in "reserved words" feature. Fix minor issues with typings in generated files.
…licts. Added generated ApiEntities (record, reducer & selector) files.
@bflamand
Copy link
Contributor Author

There is currently an issue when "useInterfaces: false". This is why one of the build steps failed. I will fix this.

@bflamand
Copy link
Contributor Author

bflamand commented Dec 1, 2021

Can someone please take a look at reviewing/merging this?
technical committee: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

…iguration variables are not found. fix minor issue with space vs tab in mustache files. Fix compilation issues in some cases when using async mode.
@bflamand bflamand requested a review from JFCote December 24, 2021 16:45
Copy link
Member

@JFCote JFCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JFCote
Copy link
Member

JFCote commented Dec 24, 2021

@bflamand Can you update your branch. It should fix the Docs up to date and Samples up to date test.

@bflamand
Copy link
Contributor Author

yep, I was already on this...

@JFCote
Copy link
Member

JFCote commented Dec 24, 2021

@bflamand not sure why it's not passing but it's not your fault since you generated the related samples. I will let the others from the technical committee validate this and merge.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@bflamand
Copy link
Contributor Author

bflamand commented Dec 24, 2021

I agree @JFCote... I really generated all playframework samples, etc.
I also tried to generate everything outside of playframework files, but got into issues with unix vs windows file path everywhere. So I reverted my last push. Hopefully someone can help...
The differences seams to be related to the version that has changed from "(5.3.1)." to "5.4.0-SNAPSHOT" but someone has forgot to update generation for all files. I tried to do it on my side, but was not able to because of the aforementioned issue of unix vs windows paths...

@wing328
Copy link
Member

wing328 commented Jan 2, 2022

@wing328
Copy link
Member

wing328 commented Jan 2, 2022

@bflamand thanks for the PR. My only suggestion is regarding the following:

    private static final String X_JWKS_URL = "x-jwksUrl";
    private static final String X_TOKEN_INTROSPECT_URL = "x-tokenIntrospectUrl";

Ref: https://github.com/OpenAPITools/openapi-generator/pull/10901/files#diff-7ae256bbbecfb39c7b23e50a2835712533d614aa3c5fd31a68cb08e0651203f3R48

Can we use kebab-case instead as that's the convention we've in this project? i.e.

    private static final String X_JWKS_URL = "x-jwks-url";
    private static final String X_TOKEN_INTROSPECT_URL = "x-token-introspect-url";

Please feel free to update it in a separate PR as I'll merge this one for the time being.

@wing328 wing328 merged commit 5152f8d into OpenAPITools:master Jan 2, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 2, 2022
@bflamand bflamand deleted the java_playframework_add_support_for_oauth2_accesstoken_validation branch May 10, 2022 15:33
Arpit-yb added a commit to yugabyte/yugabyte-db that referenced this pull request Nov 14, 2025
…arta namespace

Summary:
Current openapi-generator version only supports the javax namespace, which is used by Spring v5.x. However, as part of [[ https://yugabyte.atlassian.net/browse/PLAT-18516 | PLAT-18516 ]], we need to upgrade to Spring 6.x since 5.x is already EOLed.

We are updating the openapi-generator templates to version 7.17. This update is being done by inspecting the commits went between 5.x and 7.17 and applying them manually to each file.

Version 7.17 also introduces an in-built way to perform OAuth 0 token validation (ref: PR [[ OpenAPITools/openapi-generator#10901 | #10901) ]]. However, this feature has been commented out for now since YBA already relies on pac4j for authentication.

Test Plan:
Tested locally
dev-itests
unit tests
v2 iTests

Reviewers: #yba-api-review, sneelakantan, dkumar, aaryan.chauhan

Reviewed By: #yba-api-review, sneelakantan

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D48223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants