Skip to content

Conversation

@zhuangheihei
Copy link
Contributor

@zhuangheihei zhuangheihei commented Nov 18, 2021

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

To close #10321

…return-parser-exception-instead-of-npe

# Conflicts:
#	modules/openapi-generator/src/main/java/org/openapitools/codegen/config/CodegenConfigurator.java
…pe' of github.com:zhuangheihei/openapi-generator into OpenAPITools#10321-return-parser-exception-instead-of-npe
@wing328 wing328 changed the title #10321 return parser exception instead of npe Better handling of NPE in parser when referencing invalid schema Nov 21, 2021
@wing328 wing328 added this to the 5.3.1 milestone Nov 21, 2021
@wing328 wing328 merged commit 606db36 into OpenAPITools:master Nov 21, 2021
@wing328
Copy link
Member

wing328 commented Nov 21, 2021

@zhuangheihei thanks for the PR, which has been merged into the master.

@zhuangheihei
Copy link
Contributor Author

Thank you @wing328 so much for taking the time to review the PR and merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NullPointerException in parser when referencing invalid schema

2 participants