Julia template: `eval` of `parse` anti-pattern

[luke-kiernan]

The julia-server and julia-client generators emit the OpenAPI.property_type discriminator resolver using eval(Base.Meta.parse("ModelName")). The model types are already in scope in the generated module, so straight ModelName works: ~30× faster on the resolver call and pre-compilation friendly, while keeping the behavior the same.

Relevant template pieces: lines 16, 18 here and here: simply replace with return {{modelName}} and return {{.}}.

Worth confirming {{modelName}} is always a valid Julia identifier (true for normal model names) before merging.

[luke-kiernan]

Upon further thought: if ModelName worked in all intended cases, surely that's what'd be there. What's the case then where ModelName doesn't work? And could we get a separate template for the case where ModelName does work?

[wing328]

What's the case then where ModelName doesn't work?

No idea. We can investigate further if such case emerge.

And could we get a separate template for the case where ModelName does work?

You can use customized templates, e.g. -t in CLI