Merged
Conversation
joernu76
approved these changes
May 16, 2021
| } | ||
|
|
||
|
|
||
| def os_fs_create_dir(dir): |
Member
There was a problem hiding this comment.
Mmh. I think we need to go to an fs-only approach in combination with validating/converting any path communicated from an external source (QT-dialogues, JSON files, etc.).
Good start in doing that.
| MSS_CONFIG_PATH = os.getenv("MSS_CONFIG_PATH", os.path.join(HOME, ".config", "mss")) | ||
| if not os.path.exists(MSS_CONFIG_PATH): | ||
| os.makedirs(MSS_CONFIG_PATH) | ||
| if '://' in MSS_CONFIG_PATH: |
Member
There was a problem hiding this comment.
needs to be factored into a conversion/fs-validation routine.
Later.
|
|
||
| self.view = view | ||
| self.load = Loader(MSS_CONFIG_PATH, verbose=False) | ||
| if '://' in MSS_CONFIG_PATH: |
Member
There was a problem hiding this comment.
This needs to be moved. We need a "cache" directory here.
Later.
Marilyth
pushed a commit
to Marilyth/MSS
that referenced
this pull request
May 21, 2021
* preparations for coverage tests * ignore some more dirs * enabled project delete tests * added further utils tests, improved get_recent_pid * improved tests, enabled skipped tests * improved waypoint merge tests * skipped random failing tests * skyfield Loader files saved to fs dir * fs or os makedirs * flake8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.