Merged
Conversation
ReimarBauer
reviewed
Apr 30, 2021
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
please add in a comment the deprecation fixed
| import imp | ||
| import importlib | ||
| import importlib.machinery | ||
| import os |
joernu76
force-pushed
the
issue863-partly
branch
from
62586ba to
5a10d70
Compare
Fixed * conftest.py:30: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses * mslib/msui/mscolab_project.py:486: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. * mslib/msui/mscolab_project.py:647: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python. * mslib/msui/topview.py:354: DeprecationWarning: In future, it will be an error for 'np.bool_' scalars to be interpreted as an index See issue #863
Member
Author
|
Updated commit message with list of fixed issues. Lots of stuff left, but probably nothing that will fail our code in the near future. |
Member
Author
Done. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #863