improved io import tests - #2014
Merged
Merged
Conversation
ReimarBauer
commented
Sep 7, 2023
| import_plugins = { | ||
| "Text": ["txt", "mslib.plugins.io.text", "load_from_txt"], | ||
| "FliteStar": ["fls", "mslib.plugins.io.flitestar", "load_from_flitestar"], | ||
| "TXT": ["txt", "mslib.plugins.io.text", "load_from_txt"], |
Member
Author
There was a problem hiding this comment.
hmm, that needs a further review
We need one more test.
Member
|
I do not understand neither the problem nor the solution. |
Member
Author
|
The test was able to do something without that the files exists and didn't fail. So it can't been tested if something was imported. look for. f'test_import{ext}' |
joernu76
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2004
Does this PR introduce a breaking change?
changed the timeout for pytest to 30 seconds. Fixed the import io tests.
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>