Rename mscolab operation#1313
Merged
ReimarBauer merged 7 commits intoOpen-MSS:developfrom Jan 13, 2022
Merged
Conversation
ReimarBauer
requested changes
Dec 21, 2021
Member
There was a problem hiding this comment.
I had a first view on it.
A few things more needs a trigger.
The renamed OP is active, the description should be shown too.
The OP name is also on the *View Windows
The title of the window needs also to update the name.
For ideas about the latter two see #1210
ReimarBauer
requested changes
Jan 3, 2022
Member
There was a problem hiding this comment.
For a user per operation that is now correct. Have a look on an other user in the OP having that open while it gets renamed. multiuser has the old name in the list.
We have to send an event over socketio so that the other user interface also gets updated. For an example:
ReimarBauer
approved these changes
Jan 13, 2022
Member
|
We have to review on all existing actions the communication state over socketio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #910