changes on UI and models for using categories#1191
Merged
joernu76 merged 5 commits intoOpen-MSS:developfrom Sep 7, 2021
Merged
changes on UI and models for using categories#1191joernu76 merged 5 commits intoOpen-MSS:developfrom
joernu76 merged 5 commits intoOpen-MSS:developfrom
Conversation
Member
Author
|
I look next on filing a default on project creation from the mss_settings.json Also missing is a validation on input of the category name. |
joernu76
requested changes
Sep 6, 2021
| self.add_proj_dialog.buttonBox.accepted.connect(self.add_project) | ||
| self.add_proj_dialog.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setEnabled(False) | ||
| self.add_proj_dialog.path.textChanged.connect(check_and_enable_project_accept) | ||
| self.add_proj_dialog.description.textChanged.connect(check_and_enable_project_accept) |
Member
There was a problem hiding this comment.
This should not have been removed.?
joernu76
reviewed
Sep 7, 2021
mslib/msui/mscolab.py
Outdated
| self.add_proj_dialog.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setEnabled(False) | ||
| self.add_proj_dialog.path.textChanged.connect(check_and_enable_project_accept) | ||
| self.add_proj_dialog.description.textChanged.connect(check_and_enable_project_accept) | ||
| self.add_proj_dialog.description.textChanged.connect(check_and_enable_project) |
joernu76
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.