Clean up utils into own submodules#1168
Merged
ReimarBauer merged 6 commits intoOpen-MSS:developfrom Aug 27, 2021
Merged
Conversation
ReimarBauer
requested changes
Aug 23, 2021
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
Much changes :)
can you please split the tests.py module too. we should have a test_ module for any (new) module in utils.
Member
|
I'm not happy with the module name "time". But I have also no better idea. |
Collaborator
Author
|
The tests belonging to a specific utils module have been moved to their own files |
Collaborator
Author
|
I should not have done that before the GSOC merge, oh god the conflicts. |
ReimarBauer
requested changes
Aug 26, 2021
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
please see comment in test_config.py
mslib/utils/_tests/test_config.py
Outdated
| # -*- coding: utf-8 -*- | ||
| """ | ||
|
|
||
| <<<<<<< HEAD |
Member
There was a problem hiding this comment.
have a look on this merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1131
Cleans up most of utils.py and groups the functions/classes into other submodules
mslib/utils/airdata.py
mslib/utils/config.py
mslib/utils/coordinate.py
mslib/utils/time.py
mslib/msui/mss_qt.py