upgrading pallet projects modules e.g. werkzeug 2.0#1160
upgrading pallet projects modules e.g. werkzeug 2.0#1160ReimarBauer merged 5 commits intoOpen-MSS:developfrom
Conversation
mslib/mscolab/_tests/test_chat.py
Outdated
| sio.on('chat-message-client', handler=handle_incoming_message) | ||
| sio.connect(self.url) | ||
| sio.emit('start', response) | ||
| sio.on('chat-message-client', handler=handle_incoming_message, namespace="/") |
There was a problem hiding this comment.
This namespace for each call seems pretty dangerous and verbose. Is this really necessary or can this somehow be configured more smartly?
According to "https://python-socketio.readthedocs.io/en/latest/server.html#namespaces" "/" is the default namespace, so this seems superfluous?
Alternatively, one can use class based namespaces.
There was a problem hiding this comment.
see
https://flask-socketio.readthedocs.io/en/latest/upgrading.html
We do have an event based communication, which is secured by a token.
On any http request the Url is verbose.
There was a problem hiding this comment.
example for using more than one namespace.
https://socket.io/docs/v3/namespaces/index.html
separation, improving, organisation can be done in a different issue.
ReimarBauer
changed the title
2 participants
No description provided.