hides subprocess windows on os.system = "nt"#1148
Conversation
|
I verified these changes on my guacamole windows MSS 5.0 installation by copying the changed utils.py to the installed location. |
mslib/utils.py
Outdated
| UR.define("pptv = 1e-12 fraction") | ||
|
|
||
|
|
||
| def windows_subprocess_startupinfo(): |
There was a problem hiding this comment.
you could simplify the code quite a bit by returning "None" for non-"nt" OS and always supplying it as an argument.
Alternatively, we could shim the subprocess.run command (https://en.wikipedia.org/wiki/Shim_(computing))
Functionally this is fine.
There was a problem hiding this comment.
I first thought I just replace it by EasyProcess, https://github.com/ponty/EasyProcess
But that is an API change and it won't go into 5.0.1. I packaged this for conda-forge for pyvirtualdisplay as a dependency.
That this happens now only on windows desktop start is the reason I choosed that filter. But anyway if it breaks after next installation something else we get faster a 5.0.2.
2 participants
No description provided.