Fatal error in config loader because of invalid character

[ReimarBauer]

On OS Windows 10 a user sees a problem loading his settings file

[joernu76]

People are using the config-thingie a lot...
The path does not look like it contains invalid characters...?

[Marilyth]

Might be an issue with fs no supporting \ in paths
fs.path.split() also doesn't work on Windows, as it only splits on /, not on \

from fs.path.split

if "/" not in path:
    return ("", path)
split = path.rsplit("/", 1)
return (split[0] or "/", split[1])

[joernu76]

fs is causing us a lot of issues.

Do you have a access to a Windows system for testing?

[joernu76]

@ReimarBauer I have the feeling that we can use either os or fs but not both. (e.g. due to "/" "").
Can you replace all os.path stuff with fs replacements? grep should discover a lot.

[Marilyth]

I have a Windows and Linux system for troubleshooting. We had multiple instances of issues with fs on Windows already.

[ReimarBauer]

On a old 2.0.1 without own configuration this does not happen on the guacamole windows 10 system.
on a recent 3.0.2 config editor opens without an error too.

[ReimarBauer]

The problem happens with saving

just

{
}

can't be saved.

[Marilyth]

The issue arises when mss_settings.py was automatically loaded.
It does not happen when no settings were loaded, and it does not happen when the setting were manually loaded.