chore: update readme and better error logging #2117
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Fixed commands (check for user) | ||
| # give hint on actual docker name container E.g. bold_buck random name | ||
| docker exec -i bold_buck psql -U citycatalyst -d postgres -v ON_ERROR_STOP=1 -c "CREATE USER climateadvisor WITH PASSWORD 'climateadvisor';" | ||
|
|
||
| docker exec -i bold_buck psql -U citycatalyst -d postgres -v ON_ERROR_STOP=1 -c "CREATE DATABASE climateadvisor OWNER climateadvisor;" |
There was a problem hiding this comment.
The setup instructions start the PostgreSQL container with --name ca-postgres, but the subsequent docker exec commands target bold_buck. Unless the user happens to have a container with that randomly generated name, these commands fail with “No such container: bold_buck”, preventing database initialization. The examples should reference ca-postgres (or explain how to discover the actual container name) so the instructions can be executed as written.
Useful? React with 👍 / 👎.
| docker exec -i ca-postgres psql -U postgres -d postgres | ||
| CREATE USER climateadvisor WITH PASSWORD 'climateadvisor'; | ||
| CREATE DATABASE climateadvisor OWNER climateadvisor; | ||
| GRANT ALL PRIVILEGES ON DATABASE climateadvisor TO climateadvisor; | ||
| ALTER USER climateadvisor CREATEDB; |
There was a problem hiding this comment.
Previously the README used a here-document to feed the SQL statements into psql. The updated snippet runs docker exec -i ca-postgres psql -U postgres -d postgres and then lists the SQL lines as separate shell commands. Executing the instructions now causes the shell to try running CREATE USER … and the other SQL as binaries, resulting in command not found and leaving the database user and schema uncreated. The SQL needs to be passed via -c arguments or wrapped again in a here-document so it executes inside psql.
Useful? React with 👍 / 👎.
|
Needed to also change in the .envs: CC_BASE_URL=http://localhost:3000 (from internal.docker....) |
| uvicorn app.main:app --host 0.0.0.0 --port 8080 --reload | ||
| ``` | ||
|
|
||
| TODO: instead of uvicorn chanfe config to use docker container here |
There was a problem hiding this comment.
Does this need to be fixed in this PR?
No description provided.