Coding - Fix unnecessary loop iteration in BRepLib::BuildCurve3d#921
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Dec 16, 2025
Merged
Coding - Fix unnecessary loop iteration in BRepLib::BuildCurve3d#921dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
BRep_Tool::CurveOnSurface expects Index >= 1, but the loop started from ii = 0, resulting in a wasted iteration that always returned a null pointer. Fixes #0032371
Member
Author
Contributor
|
The same range issue could be observed in |
Member
Author
|
Thank you a lot. I will check them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BRep_Tool::CurveOnSurface expects Index >= 1, but the loop started
from ii = 0, resulting in a wasted iteration that always returned
a null pointer.
Fixes #0032371