Skip to content

Coding - Fix unnecessary loop iteration in BRepLib::BuildCurve3d#921

Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:extra_loop_in_code
Dec 16, 2025
Merged

Coding - Fix unnecessary loop iteration in BRepLib::BuildCurve3d#921
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:extra_loop_in_code

Conversation

@dpasukhi
Copy link
Member

BRep_Tool::CurveOnSurface expects Index >= 1, but the loop started
from ii = 0, resulting in a wasted iteration that always returned
a null pointer.

Fixes #0032371

BRep_Tool::CurveOnSurface expects Index >= 1, but the loop started
  from ii = 0, resulting in a wasted iteration that always returned
  a null pointer.

Fixes #0032371
@dpasukhi
Copy link
Member Author

@dpasukhi dpasukhi merged commit 4a9f416 into Open-Cascade-SAS:IR Dec 16, 2025
24 checks passed
@dpasukhi dpasukhi deleted the extra_loop_in_code branch December 16, 2025 09:22
@github-project-automation github-project-automation bot moved this from Todo to Done in Maintenance Dec 16, 2025
@dpasukhi dpasukhi self-assigned this Dec 16, 2025
@dpasukhi dpasukhi added the 1. Coding Coding rules, trivial changes and misprints label Dec 16, 2025
@gkv311
Copy link
Contributor

gkv311 commented Dec 23, 2025

The same range issue could be observed in ShapeUpgrade_UnifySameDomain, which could be detected by throwing exception inside BRep_Tool::CurveOnSurface() (and in similar method nearby).

@dpasukhi
Copy link
Member Author

dpasukhi commented Dec 23, 2025

Thank you a lot. I will check them.
I will try to resolve them faster.
Tomorrow I'm going to apply coding refactoring with types (int/double/handle...). Later container direct declarations on the week
It will leads to merge conflicts mess for all old changes :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Coding Coding rules, trivial changes and misprints

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants