Modeling - BRepFilletAPI_MakeFillet::Add hangs on adding edge#859
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Nov 27, 2025
Merged
Modeling - BRepFilletAPI_MakeFillet::Add hangs on adding edge#859dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
ChFi3d_Builder_1: Face reordering logic is updated to process correctly face vertices that are connected to more then 2 face edges.
AtheneNoctuaPt
added
2. Bug
There was a problem hiding this comment.
Pull request overview
This PR fixes a hang in BRepFilletAPI_MakeFillet::Add when adding edges. The root cause is in the face reordering logic of ChFi3d_Builder_1, which previously assumed face vertices connect to exactly 2 edges. The fix updates the logic to handle vertices connected to more than 2 face edges.
Key changes:
- Refactored the
ReorderFacesfunction to iterate through all edges at a vertex instead of assuming only two edges exist - Replaced manual face swapping with
std::swapfor cleaner code - Removed debug output statements and unused debug declarations
dpasukhi
approved these changes
Nov 27, 2025
dpasukhi
changed the title
dpasukhi
pushed a commit
to dpasukhi/OCCT
that referenced
this pull request
Dec 5, 2025
…ascade-SAS#859) - Refactored the `ReorderFaces` function to iterate through all edges at a vertex instead of assuming only two edges exist - Replaced manual face swapping with `std::swap` for cleaner code - Removed debug output statements and unused debug declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChFi3d_Builder_1: Face reordering logic is updated to process correctly face vertices that are connected to more then 2 face edges.