Testing - Update samples C++ version#606
Merged
dpasukhi merged 4 commits intoOpen-Cascade-SAS:IRfrom Jul 12, 2025
Merged
Conversation
Update C++ standard to C++17 in project files and action configuration
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C++ standard from C++11/GNU++11 to C++17 across all sample projects and build configurations. The purpose is to modernize the codebase to leverage C++17 features and maintain compatibility with current development standards.
Key changes include:
- Updating Qt project files to use C++17 standard instead of GNU++11
- Configuring Visual Studio project files to use C++17 language standard
- Setting CMake projects to require C++17 standard
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| samples/qt/Tutorial/Tutorial.pro | Updated QMAKE_CXXFLAGS to use C++17 for Unix and Windows |
| samples/qt/OCCTOverview/OCCTOverview.pro | Updated QMAKE_CXXFLAGS to use C++17 for Unix and Windows |
| samples/qt/IESample/IESample.pro | Updated QMAKE_CXXFLAGS to use C++17 for Unix and Windows |
| samples/qt/FuncDemo/FuncDemo.pro | Updated QMAKE_CXXFLAGS to use C++17 for Unix and Windows |
| samples/qt/AndroidQt/OCCT.pri | Added C++17 standard flag for Android and Windows builds |
| samples/mfc/standard/mfcsample/adm/win/vc10/mfcsample.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/mfc/standard/mfcsample/CMakeLists.txt | Set CMAKE_CXX_STANDARD to 17 with required flag |
| samples/mfc/standard/04_HLR/adm/win/vc10/HLR.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/mfc/standard/04_HLR/CMakeLists.txt | Set CMAKE_CXX_STANDARD to 17 with required flag |
| samples/mfc/standard/03_ImportExport/adm/win/vc10/ImportExport.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/mfc/standard/03_ImportExport/CMakeLists.txt | Set CMAKE_CXX_STANDARD to 17 with required flag |
| samples/mfc/standard/02_Modeling/adm/win/vc10/Modeling.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/mfc/standard/02_Modeling/CMakeLists.txt | Set CMAKE_CXX_STANDARD to 17 with required flag |
| samples/mfc/standard/01_Geometry/adm/win/vc10/Geometry.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/mfc/standard/01_Geometry/CMakeLists.txt | Set CMAKE_CXX_STANDARD to 17 with required flag |
| samples/CSharp/OCCTProxy_D3D/OCCTProxy_D3D.vcxproj | Added LanguageStandard property set to stdcpp17 |
| samples/CSharp/OCCTProxy/OCCTProxy.vcxproj | Added LanguageStandard property set to stdcpp17 |
| .github/actions/build-tinspector/action.yml | Updated Inspector repository commit hash |
| <IntDir Condition="'$(Configuration)|$(Platform)'=='Release|x64'">.\win64\obj\</IntDir> | ||
| <LinkIncremental Condition="'$(Configuration)|$(Platform)'=='Release|x64'">false</LinkIncremental> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
[nitpick] The PropertyGroup for LanguageStandard should be placed after the existing PropertyGroup sections that define configuration-specific properties for better organization and consistency with other vcxproj files in this PR.
dpasukhi
added a commit
that referenced
this pull request
Oct 18, 2025
- Updating Qt project files to use C++17 standard instead of GNU++11 - Configuring Visual Studio project files to use C++17 language standard - Setting CMake projects to require C++17 standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update C++ standard to C++17 in project files and action configuration