Skip to content

Fix swin dataloader bug #8037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 32 commits into from
Apr 19, 2022
Merged

Fix swin dataloader bug #8037

Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e6e6973
fix reduce_sum scalar check bug
BBuf Mar 22, 2022
a0abdd5
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 23, 2022
00522df
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 23, 2022
68e0e08
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 24, 2022
0b90f9b
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 28, 2022
d81aa80
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 29, 2022
81954d7
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 29, 2022
c910fbe
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 29, 2022
32702cf
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 29, 2022
9fa0513
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 30, 2022
8402ce3
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Mar 31, 2022
e3bf835
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 1, 2022
7a46669
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 2, 2022
5786ed5
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 2, 2022
1f66c27
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 3, 2022
265c15a
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 5, 2022
68f1baf
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 6, 2022
8f4ce10
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 7, 2022
df08558
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 7, 2022
e811e5b
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 8, 2022
f7aba4b
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 8, 2022
af091f1
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 11, 2022
f8adac3
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 12, 2022
c1d1438
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 12, 2022
a8b6f04
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 14, 2022
f1ed159
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 14, 2022
6020d18
Merge branch 'master' of github.com:Oneflow-Inc/oneflow
BBuf Apr 18, 2022
aea2e5b
fix swin_dataloader import bug
BBuf Apr 18, 2022
118b1e6
Update test_speed_multi_client.sh
BBuf Apr 19, 2022
88e0873
Merge branch 'master' into fix_swin_dataloader_bug
BBuf Apr 19, 2022
5a9dc54
Merge branch 'master' into fix_swin_dataloader_bug
mergify[bot] Apr 19, 2022
7b81a14
Merge branch 'master' into fix_swin_dataloader_bug
BBuf Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ jobs:
uses: actions/checkout@v2
with:
repository: Oneflow-Inc/models
ref: 51933864c0f8305db27d47db1955fe1647620b73
ref: d6b2b8260e87541726ed87361171438d258e6a4d
path: oneflow-models
- name: ResNet50 Graph DDP test
id: models-resnet50
Expand Down
6 changes: 3 additions & 3 deletions ci/test/test_speed_multi_client.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ python3 scripts/compare_speed_with_pytorch.py Vision/classification/image/resnet
python3 scripts/compare_speed_with_pytorch.py Vision/classification/image/resnet50/models/resnet50.py resnet50 2x3x224x224 --no-show-memory --times 200 | check_relative_speed 0.99 | write_to_file_and_print
python3 scripts/compare_speed_with_pytorch.py Vision/classification/image/resnet50/models/resnet50.py resnet50 1x3x224x224 --no-show-memory --times 200 | check_relative_speed 0.95 | write_to_file_and_print

python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 1 | check_relative_speed 0.91 | write_to_file_and_print
python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 4 | check_relative_speed 0.91 | write_to_file_and_print
python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 8 | check_relative_speed 0.93 | write_to_file_and_print
python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 1 | write_to_file_and_print
python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 4 | write_to_file_and_print
python3 scripts/swin_dataloader_compare_speed_with_pytorch.py --batch_size 32 --num_workers 8 | write_to_file_and_print

export OMP_NUM_THREADS=1
python3 -m oneflow.distributed.launch --nproc_per_node 2 scripts/compare_speed_with_pytorch.py Vision/classification/image/resnet50/models/resnet50.py resnet50 16x3x224x224 --no-show-memory --times 100 --ddp | check_relative_speed 1.12 | check_millisecond_time 136.3 2 | write_to_file_and_print
Expand Down