Skip to content

Dev deepfm multicol oneemb#339

Merged
Liuxinman merged 245 commits intomainfrom
dev_deepfm_multicol_oneemb
May 20, 2022
Merged

Dev deepfm multicol oneemb#339
Liuxinman merged 245 commits intomainfrom
dev_deepfm_multicol_oneemb

Conversation

@Liuxinman
Copy link
Copy Markdown
Contributor

No description provided.

@Liuxinman Liuxinman marked this pull request as ready for review May 16, 2022 02:38
Copy link
Copy Markdown
Contributor

@ShawnXuan ShawnXuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecommenderSystems/deepfm/tools/criteo_parquet.py this file is not ready, suggest to remove it in this pr.


self.dnn_layer = DNN(
in_features=embedding_vec_size * (num_dense_fields + num_sparse_fields),
hidden_units=dnn + [1],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 1 是不是应该作为o ut_features 传过去

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以

@Liuxinman Liuxinman merged commit a0c9af5 into main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants