Skip to content

refine embedding options #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShawnXuan merged 2 commits into from
Feb 4, 2022
Merged

refine embedding options #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e4012
refine options
guo-ran Jan 29, 2022
58017ee
rename args
guo-ran Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecommenderSystems/dlrm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def str_list(x):
parser.add_argument("--embedding_split_axis", type=int, default=-1, help="-1: no split")
parser.add_argument("--column_size_array", type=int_list, help="column_size_array")
parser.add_argument(
"--blocked_based_path", type=str, default="", help="path for kv store"
"--persistent_path", type=str, default="", help="path for persistent kv store"
)
parser.add_argument(
"--cache_policy", type=str_list, default="lru,none"
Expand Down
11 changes: 6 additions & 5 deletions RecommenderSystems/dlrm/models/dlrm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,18 +166,19 @@ def __init__(self, vocab_size, embed_size, args):
cache_list.append(cache)
print("cache_list", cache_list)
options = {
"dtype": flow.float,
"key_type": flow.int64,
"value_type": flow.float,
"name": "my_embedding",
"embedding_dim": embed_size,
"scale_factor": 1,
"cache" : cache_list,
"storage_dim": embed_size,
"kv_store": {
"caches" : cache_list,
"persistent_table": {
"path": args.blocked_based_path,
"path": args.persistent_path,
"physical_block_size": 512,
},
},
"default_initializer": {"type": "normal", "mean": 0, "std": 1},
"default_initializer": {"type": "normal", "mean": 0, "std": 0.05},
"columns": initializer_list,
}
super(OneEmbedding, self).__init__()
Expand Down
6 changes: 4 additions & 2 deletions RecommenderSystems/dlrm/train_one_embedding_graph.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ DEVICE_NUM_PER_NODE=4
MASTER_ADDR=127.0.0.1
NUM_NODES=1
NODE_RANK=0
DATA_DIR=/data/xiexuan/criteo1t_ofrecord_shuffle_per_day/
DATA_DIR=/data/criteo1t/dlrm_v884m_ofrecord
EMBD_SIZE=33762578
BATHSIZE=55296
export GLOG_minloglevel=2
Expand All @@ -29,7 +29,7 @@ python3 -m oneflow.distributed.launch \
--node_rank $NODE_RANK \
--master_addr $MASTER_ADDR \
train.py \
--interaction_type dot \
--interaction_type fused \
--embedding_type OneEmbedding \
--learning_rate 24 \
--batch_size $BATHSIZE \
Expand All @@ -49,3 +49,5 @@ python3 -m oneflow.distributed.launch \
--blocked_based_path $BLOCK_BASED_PATH \
--column_size_array '227605432,39060,17295,7424,20265,3,7122,1543,63,130229467,3067956,405282,10,2209,11938,155,4,976,14,292775614,40790948,187188510,590152,12973,108,36' \
--test_name 'train_one_embedding_graph_'$DEVICE_NUM_PER_NODE'gpu' | tee 'train_one_embedding_graph_'$DEVICE_NUM_PER_NODE'gpu'.log
#--eval_save_dir '/NVME0/guoran/auc/' \
#--eval_after_training \