Skip to content

Dev dlrm eval partnum #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShawnXuan merged 2 commits into from
Jan 18, 2022
Merged

Dev dlrm eval partnum #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebb50a
eval data part number
ShawnXuan Jan 18, 2022
cf5841d
fix
ShawnXuan Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RecommenderSystems/dlrm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def int_list(x):
"--dataset_format", type=str, default="ofrecord", help="ofrecord, onerec, parquet or synthetic"
)
parser.add_argument("--data_part_num", type=int, default=256)
parser.add_argument("--eval_data_part_num", type=int, default=256)
parser.add_argument(
"--data_dir", type=str, default="/dataset/wdl_ofrecord/ofrecord"
)
Expand Down
2 changes: 1 addition & 1 deletion RecommenderSystems/dlrm/models/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def make_data_loader(args, mode, is_consistent=False, data_format="ofrecord"):
elif data_format == "ofrecord":
return OFRecordDataLoader(
data_dir=args.data_dir,
data_part_num=args.data_part_num,
data_part_num=args.data_part_num if mode=='train' else args.eval_data_part_num,
part_name_suffix_length=args.data_part_name_suffix_length,
**kps
)
Expand Down