Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Examples/OneSignalDemo/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ plugins {
}

android {
namespace 'com.onesignal.sdktest'
compileSdkVersion 34
defaultConfig {
minSdkVersion 21
Expand Down Expand Up @@ -61,10 +62,11 @@ android {
}

task flavorSelection() {
if (getGradle().getStartParameter().getTaskRequests().toString().contains("Gms")) {
def tasksList = gradle.startParameter.taskRequests.toString()
if (tasksList.contains('Gms')) {
apply plugin: 'com.google.gms.google-services'
googleServices { disableVersionCheck = true }
} else {
} else if (tasksList.contains('Huawei')) {
apply plugin: 'com.huawei.agconnect'
}
}
Expand Down
3 changes: 1 addition & 2 deletions Examples/OneSignalDemo/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
xmlns:amazon="http://schemas.amazon.com/apk/res/android"
package="com.onesignal.sdktest">
xmlns:amazon="http://schemas.amazon.com/apk/res/android">

<uses-permission android:name="com.android.vending.BILLING" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import com.onesignal.notifications.IDisplayableNotification;
import com.onesignal.notifications.INotificationLifecycleListener;
import com.onesignal.notifications.INotificationWillDisplayEvent;
import com.onesignal.sdktest.BuildConfig;
import com.onesignal.sdktest.R;
import com.onesignal.sdktest.constant.Tag;
import com.onesignal.sdktest.constant.Text;
Expand All @@ -39,9 +38,8 @@ public class MainApplication extends MultiDexApplication {
private static final int SLEEP_TIME_TO_MIMIC_ASYNC_OPERATION = 2000;

public MainApplication() {
// run strict mode default in debug mode to surface any potential issues easier
if(BuildConfig.DEBUG)
StrictMode.enableDefaults();
// run strict mode to surface any potential issues easier
StrictMode.enableDefaults();
}

@SuppressLint("NewApi")
Expand Down
4 changes: 2 additions & 2 deletions Examples/OneSignalDemo/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ buildscript {
maven { url 'https://developer.huawei.com/repo/' }
}
dependencies {
classpath 'com.android.tools.build:gradle:7.2.2'
classpath 'com.android.tools.build:gradle:8.8.2'
classpath 'com.google.gms:google-services:4.3.10'
classpath 'com.huawei.agconnect:agcp:1.6.2.300'
classpath 'com.huawei.agconnect:agcp:1.9.1.304'

// TODO: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
4 changes: 2 additions & 2 deletions OneSignalSDK/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ buildscript {
targetSdkVersion: 34,
minSdkVersion: 21
]
androidGradlePluginVersion = '7.2.0'
androidGradlePluginVersion = '8.8.2'
googleServicesGradlePluginVersion = '4.3.10'
huaweiAgconnectVersion = '1.6.2.300'
huaweiAgconnectVersion = '1.9.1.304'
huaweiHMSPushVersion = '6.3.0.304'
huaweiHMSLocationVersion = '4.0.0.300'
kotlinVersion = '1.7.10'
Expand Down
4 changes: 1 addition & 3 deletions OneSignalSDK/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@
# Remove when creating an .aar build.
#android.enableAapt2=false

android.databinding.incremental = false
kapt.incremental.apt = false
android.testConfig.useRelativePath = false
org.gradle.jvmargs=-Xmx1536m

# Enables D8 for all modules.
android.enableD8 = true
Expand Down
2 changes: 1 addition & 1 deletion OneSignalSDK/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
6 changes: 6 additions & 0 deletions OneSignalSDK/onesignal/build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
plugins {
id 'com.android.library'
// There isn't Kotlin or Java code in this top-level project,
// however consumers look for an .aar file, which this causes it
// to be created.
id 'kotlin-android'
}

android {
Expand All @@ -25,6 +29,8 @@ android {
targetCompatibility JavaVersion.VERSION_1_8
}
namespace 'com.onesignal'

kotlinOptions.freeCompilerArgs += ['-module-name', namespace]
}

ext {
Expand Down
4 changes: 3 additions & 1 deletion OneSignalSDK/onesignal/maven-push.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ afterEvaluate {

publications {
release(MavenPublication) {
from components.release
afterEvaluate {
from components.findByName('release')
}

pom {
name = projectName
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import android.net.Uri
import android.os.Build
import androidx.core.app.NotificationCompat
import com.onesignal.common.AndroidUtils
import com.onesignal.core.R
import com.onesignal.core.internal.application.IApplicationService
import com.onesignal.debug.internal.logging.Logging
import com.onesignal.notifications.internal.bundle.impl.NotificationBundleProcessor
Expand Down Expand Up @@ -231,9 +230,9 @@ internal class NotificationDisplayBuilder(
if (bitmap == null) return null
try {
val systemLargeIconHeight =
contextResources!!.getDimension(R.dimen.notification_large_icon_height).toInt()
contextResources!!.getDimension(android.R.dimen.notification_large_icon_height).toInt()
val systemLargeIconWidth =
contextResources!!.getDimension(R.dimen.notification_large_icon_width).toInt()
contextResources!!.getDimension(android.R.dimen.notification_large_icon_width).toInt()
val bitmapHeight = bitmap.height
val bitmapWidth = bitmap.width
if (bitmapWidth > systemLargeIconWidth || bitmapHeight > systemLargeIconHeight) {
Expand Down
Loading