Skip to content

Conversation

@jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Jan 11, 2024

Description

One Line Summary

Bump work-runtime dependency version implementation

Details

Motivation

In #1890 we updated work-runtime dependency to the latest version (2.8.1) to prevent gradle crash with latest version of WorkManager. However, as #1915 points out, the implementation of this dependency still uses an older version. This PR will align versions.

Testing

Manual testing

Built app on Android 12 and 13 emulators and ran unit tests with updated dependency version to ensure no issues.

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Work manager dependency was updated in #1890 but missed updating the implementation
@jennantilla
Copy link
Contributor Author

Noting that our Test/build setup Android step is failing; a fix is being investigated separate of this merge.

@jennantilla jennantilla merged commit e66b051 into user-model/main Jan 11, 2024
@jennantilla jennantilla deleted the fix/work-runtime_notifications_dependency_bump branch January 11, 2024 23:01
@jennantilla jennantilla mentioned this pull request Jan 11, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…s_dependency_bump

[Fix] Bump work-runtime dependency version implementation
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…s_dependency_bump

[Fix] Bump work-runtime dependency version implementation
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
…s_dependency_bump

[Fix] Bump work-runtime dependency version implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants