Skip to content

[5.0.0] Make subscribers in EventProducer synchronized #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emawby merged 1 commit into from
Aug 8, 2023
Merged

[5.0.0] Make subscribers in EventProducer synchronized #1796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion OneSignalSDK/onesignal/core/src/main/java/com/onesignal/common/events/EventProducer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.onesignal.common.events
import com.onesignal.common.threading.suspendifyOnMain
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import java.util.*

/**
* A standard implementation that implements [IEventNotifier] and additional functionality to make
Expand All @@ -13,7 +14,7 @@ open class EventProducer<THandler> : IEventNotifier<THandler> {
override val hasSubscribers: Boolean
get() = _subscribers.any()

private val _subscribers: MutableList<THandler> = mutableListOf()
private val _subscribers: MutableList<THandler> = Collections.synchronizedList(mutableListOf())

override fun subscribe(handler: THandler) {
_subscribers.add(handler)
Expand Down