builder API: remove blinded blob sidecar#13202
Merged
terencechain merged 15 commits intodevelopfrom Nov 29, 2023
Merged
Conversation
|
|
||
| return sidecars, nil | ||
| } | ||
| //func blindBlobsBundleToSidecars(bundle *enginev1.BlindedBlobsBundle, blk interfaces.ReadOnlyBeaconBlock) ([]*ethpb.BlindedBlobSidecar, error) { |
Collaborator
There was a problem hiding this comment.
we can just delete these
Comment on lines
+47
to
+48
| // bidKzgCommitments holds the KZG commitments for a builder's beacon block. | ||
| var bidKzgCommitments [][]byte //TODO: possibly change the architecture here to not use this package variable |
Collaborator
There was a problem hiding this comment.
let's just remove these
| // TODO: update this for blobBundle processing | ||
| //bidKzgCommitments = nil // Reset blind blobs bundle after use. | ||
| //if err != nil { | ||
| // return nil, status.Errorf(codes.Internal, "Could not convert blind blobs bundle to sidecar: %v", err) | ||
| //} |
Collaborator
There was a problem hiding this comment.
same, we can remove these for now
james-prysm
force-pushed
the
builder-api-deneb-fix
branch
from
791aa33 to
5f0d2eb
Compare
james-prysm
force-pushed
the
builder-api-deneb-fix
branch
from
5f0d2eb to
410c515
Compare
james-prysm
commented
Nov 28, 2023
| }).Info("Retrieved full payload from builder") | ||
|
|
||
| bundle, err := unblindBlobsSidecars(u.blobs, blobsBundle) | ||
| sidecars, err := unblindBlobsSidecars(u.b, blobsBundle) |
Contributor
Author
There was a problem hiding this comment.
should I replace this with buildBlobSidecars function? I would need to add the blobs bundle to the cache, perhaps I add it to the cache when I submit blinded block?
james-prysm
commented
Nov 28, 2023
| } | ||
|
|
||
| func unblindBlobsSidecars(blindSidecars []*ethpb.SignedBlindedBlobSidecar, bundle *enginev1.BlobsBundle) ([]*ethpb.SignedBlobSidecar, error) { | ||
| func unblindBlobsSidecars(block interfaces.SignedBeaconBlock, bundle *enginev1.BlobsBundle) ([]*ethpb.BlobSidecar, error) { |
Contributor
Author
There was a problem hiding this comment.
If I use buildBlobSidecars then I don't need this function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Does not address proposer changes, Beacon API changes, and some deneb unit tests are commented out to be addressed in subsequent PRs
Which issues(s) does this PR fix?
Fixes #13201 and part of #13157,#13155
Addresses ethereum/builder-specs#90
Other notes for review