Update Substrate to April 2023 snapshot#67
Merged
JoshOrndorff merged 13 commits intomainfrom Apr 20, 2023
Merged
Conversation
JoshOrndorff
changed the title
Contributor
Author
|
There is a refactor of the keystore in paritytech/substrate#13615 an two following PRs that are affecting the wallet. Overall, it will probably be nicer in the long run, but will take a little refactoring on our side too. |
coax1d
approved these changes
Apr 18, 2023
Contributor
coax1d
left a comment
coax1d
left a comment
There was a problem hiding this comment.
Looks good is this all that was required for updating?
Co-authored-by: Andrew <[email protected]>
Contributor
Author
|
No, there is more needed. The client-side doesn't compile yet. |
Contributor
Author
|
This is almost done now. Looks like there is one legit test failure: I reproduced it locally. Haven't dug in yet. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.