Accept Windows TCP connect timeout in ExceptionContractFixture#710
Merged
rhysparry merged 1 commit intoApr 30, 2026
Merged
Conversation
On Windows 2019, disposing the port forwarder causes TCP SYN packets to be dropped rather than immediately refused (no RST), so the client gets a connect timeout instead of "Connection refused". Add the Windows timeout message to the ContainAny assertion so the test passes on both platforms. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
LukeButters
approved these changes
Apr 29, 2026
rhysparry
deleted the
rhys/eft-3214/fix-exception-contract-windows-connection-refused
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"The client was unable to establish the initial connection within the timeout"instead of"Connection refused"or"actively refused it".WhenTheListeningRequestFailsToBeSent_AsTheServiceDoesNotAcceptTheConnectionwas asserting only on Linux/Windows-RST message strings, causing it to fail on Windows 2019.ContainAnyalternative so the test passes on both platforms.Test plan
WhenTheListeningRequestFailsToBeSent_AsTheServiceDoesNotAcceptTheConnectionand the two related variants — 3/3 pass locallyExceptionContractFixturefailure seen in nightly builds 4709 and 4710🤖 Generated with Claude Code