edit commands #76
Merged
edit commands #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinebit
force-pushed
the
pinebit/edit-commands
branch
from
8c94ae4 to
802953a
Compare
OisinKyne
approved these changes
Dec 9, 2025
|
|
||
| # Or, if you prefer running it in Docker | ||
| # (replace 'latest' with the most recent version if needed: https://hub.docker.com/r/obolnetwork/charon/tags) | ||
| docker run --rm -v "$(pwd):/opt/charon" obolnetwork/charon:latest alpha edit add-operators --new-operator-enrs=enr:-JG4QH... --private-key-file=/opt/charon/.charon/charon-enr-private-key --lock-file=/opt/charon/.charon/cluster-lock.json --validator-keys-dir=/opt/charon/.charon/validator_keys --output-dir=/opt/charon/output |
Contributor
There was a problem hiding this comment.
Suggested change
| docker run --rm -v "$(pwd):/opt/charon" obolnetwork/charon:latest alpha edit add-operators --new-operator-enrs=enr:-JG4QH... --private-key-file=/opt/charon/.charon/charon-enr-private-key --lock-file=/opt/charon/.charon/cluster-lock.json --validator-keys-dir=/opt/charon/.charon/validator_keys --output-dir=/opt/charon/output | |
| docker run --rm -v "$(pwd):/opt/charon" -w "/opt/charon" obolnetwork/charon:latest alpha edit add-operators --new-operator-enrs=enr:-JG4QH... --output-dir=/opt/charon/output |
would something like this work? (haven't tested yet)
Contributor
Author
There was a problem hiding this comment.
Updated for all edit commands
|
|
||
| ### For New Operators | ||
|
|
||
| New operators being added should run the same command but only need to provide their private key file and the cluster lock file (they won't have validator keys yet): |
Contributor
There was a problem hiding this comment.
Suggested change
| New operators being added should run the same command but only need to provide their private key file and the cluster lock file (they won't have validator keys yet): | |
| New operators being added should run the same command but only need to provide their private key file and the cluster lock file (they won't have validator keys yet): |
How would you feel about permitting https:// for the lock file flag? allowing the new operator to not have to juggle a file into the right location themselves? [Nice to have but potentially good to have in scope of an audit :) ]
Contributor
Author
There was a problem hiding this comment.
Good idea, logged: ObolNetwork/charon#4166
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
editcommands documentation.